Changeset 10920

Timestamp:

04/22/2021 12:56:31 AM (5 years ago)

Author:

dd32

Message:

Handbooks/HelpHub: Replace accented characters before converting a title into a slug for use as page anchors.

Fixes #5711.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins

Files:

• handbook/inc/table-of-contents.php (modified) (2 diffs)
• support-helphub/inc/table-of-contents-lite/includes/class-table-of-contents-lite.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/table-of-contents.php

@@ -93 +93 @@
                                 $last_item = $item[2];
 
-                                $id = sanitize_title_with_dashes( $item[3] );
+                                $id = sanitize_title_with_dashes( remove_accents( $item[3] ) );
                                 // Append unique suffix if anchor ID isn't unique.
                                 $count = 2;
@@ -121 +121 @@
                         $replacement = '';
                         $matches[] = $item[0];
-                        $id = sanitize_title_with_dashes($item[2]);
+                        $id = sanitize_title_with_dashes( remove_accents( $item[2] ) );
 
                         // Append unique suffix if anchor ID isn't unique.

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-helphub/inc/table-of-contents-lite/includes/class-table-of-contents-lite.php

@@ -255 +255 @@
                                 }
                                 $last_item = $item[2];
-                                $toc .= sprintf( '<li><a href="#%1s">%2s</a>', sanitize_title_with_dashes( $item[3] ), $item[3] );
+                                $toc .= sprintf( '<li><a href="#%1s">%2s</a>', sanitize_title_with_dashes( remove_accents( $item[3] ) ), $item[3] );
                         }
                         $toc .= '</ul></div>';
@@ -297 +297 @@
                         $replacement = '';
                         $matches[]   = $item[0];
-                        $id          = sanitize_title_with_dashes( $item[2] );
+                        $id          = sanitize_title_with_dashes( remove_accents( $item[2] ) );
                         if ( ! $first ) {
                                 $replacement .= '<p class="toc-jump"><a href="#top">' . __( 'Top &uarr;', 'wporg-forums' ) . '</a></p>';