Changeset 10928 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/register.php

Timestamp:

04/27/2021 04:24:21 AM (4 years ago)

Author:

dd32

Message:

Login: Allow registrations with "low reCaptcha scores" to register, but go into a pending-moderation state.

This will allow legitimate users who receive a "Please try again" error to be manually approved.

This will also allow us to experiment with more aggressive anti-spam measures, as the majority of current spam registrations are human generated.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/register.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/register.php

@@ -15 +15 @@
 }
 
-$error_user_login = $error_user_email = $error_recapcha_status = $error_akismet = $terms_of_service_error = false;
+$error_user_login = $error_user_email = $error_recapcha_status = $terms_of_service_error = false;
 if ( $_POST ) {
 
@@ -34 +34 @@
     // handle user registrations.
     if ( ! $error_user_login && ! $error_user_email && ! $terms_of_service_error ) {
-        if ( ! wporg_login_check_recapcha_status( 'register' ) ) {
+
+        $recaptcha = wporg_login_check_recapcha_status( 'register', false /* Allow low scores to pass through */ );
+
+        if ( ! $recaptcha ) {
             $error_recapcha_status = true;
         } else {
-            $akismet = wporg_login_check_akismet( $user_login, $user_email );
-
             $tos_meta_key = WPOrg_SSO::TOS_USER_META_KEY;
             $meta = [
                 'user_mailinglist' => $user_mailinglist,
-                'akismet_result'   => $akismet,
                 $tos_meta_key      => $terms_of_service,
             ];
 
-            if ( 'spam' === $akismet ) {
-                $error_akismet = true;
-            } else {
-                wporg_login_create_pending_user( $user_login, $user_email, $meta );
-                die();
-            }
+            wporg_login_create_pending_user( $user_login, $user_email, $meta );
+            die();
         }
     }
@@ -123 +119 @@
     </p>
     <?php
-        if ( $error_recapcha_status || $error_akismet ) {
+        if ( $error_recapcha_status ) {
             echo '<div class="message error"><p>' . __( 'Please try again.', 'wporg' ) . '</p></div>';
         }