Changeset 10943

Timestamp:

05/04/2021 12:21:17 AM (4 years ago)

Author:

dd32

Message:

Translations: When searching checking claimed installed language packs, check the field we expect is set.

This avoids PHP Notices when the incoming data is in an unexpected format (such as generated by an app that doesn't set the PO-Revision-Date header).
This shouldn't be a logical difference, as strtotime() would return false in these situations.

File:

• sites/trunk/api.wordpress.org/public_html/translations/lib.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/translations/lib.php

@@ -238 +238 @@
     foreach ( $translations_for_current as $language_pack ) {
         $update = true;
-        if ( isset( $language_data[ $language_pack['language'] ] ) ) {
+        if ( isset( $language_data[ $language_pack['language'] ]['PO-Revision-Date'] ) ) {
             $wporg_updated = strtotime( $language_pack['updated'] );
             $site_updated  = strtotime( $language_data[ $language_pack['language'] ]['PO-Revision-Date'] );