Changeset 10945

Timestamp:

05/04/2021 04:25:36 AM (4 years ago)

Author:

dd32

Message:

Handbooks/HelpHub: Replace accented characters before converting a title into a slug for use as page anchors. Take Two.

This time use sanitize_title() so that sanitize_title_with_dashes() gets called with save context rather than display which properly strips any remaining entities.

Follow up to [10920].
Fixes #5711.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins

Files:

• handbook/inc/table-of-contents.php (modified) (2 diffs)
• support-helphub/inc/table-of-contents-lite/includes/class-table-of-contents-lite.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/table-of-contents.php

@@ -131 +131 @@
                 $last_item = $item[2];
 
-                $id = sanitize_title_with_dashes( remove_accents( $item[3] ) );
+                $id = sanitize_title( $item[3] );
                 // Append unique suffix if anchor ID isn't unique.
                 $count = 2;
@@ -159 +159 @@
             $replacement = '';
             $matches[] = $item[0];
-            $id = sanitize_title_with_dashes( remove_accents( $item[2] ) );
+            $id = sanitize_title( $item[2] );
 
             // Append unique suffix if anchor ID isn't unique.

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-helphub/inc/table-of-contents-lite/includes/class-table-of-contents-lite.php

@@ -255 +255 @@
                 }
                 $last_item = $item[2];
-                $toc .= sprintf( '<li><a href="#%1s">%2s</a>', sanitize_title_with_dashes( remove_accents( $item[3] ) ), $item[3] );
+                $toc .= sprintf( '<li><a href="#%1s">%2s</a>', sanitize_title( $item[3] ), $item[3] );
             }
             $toc .= '</ul></div>';
@@ -297 +297 @@
             $replacement = '';
             $matches[]   = $item[0];
-            $id          = sanitize_title_with_dashes( remove_accents( $item[2] ) );
+            $id          = sanitize_title( $item[2] );
             if ( ! $first ) {
                 $replacement .= '<p class="toc-jump"><a href="#top">' . __( 'Top &uarr;', 'wporg-forums' ) . '</a></p>';