Changeset 11015

Timestamp:

06/07/2021 01:36:48 AM (5 years ago)

Author:

dd32

Message:

Translate: Custom GlotPress Warnings: Add support for WordPress's %l formatter used via wp_sprintf().

Fixes warnings like The translation contains the following unexpected placeholders: %l.
See ​https://wordpress.slack.com/archives/C0AFVRSHX/p1623024751163600

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-custom-warnings/wporg-gp-custom-warnings.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-custom-warnings/wporg-gp-custom-warnings.php

@@ -276 +276 @@
         public function warning_unexpected_sprintf_token( $original, $translation ) {
                 $unexpected_tokens = [];
-                $is_sprintf        = preg_match( '!%((\d+\$(?:\d+)?)?[bcdefgosux])!i', $original );
+                $is_sprintf        = preg_match( '!%((\d+\$(?:\d+)?)?[bcdefgosuxl])!i', $original );
 
                 // Find any percents that are not valid or escaped.
@@ -285 +285 @@
                         foreach ( $m['char'] as $i => $char ) {
                                 // % is included for escaped %%.
-                                if ( false === strpos( 'bcdefgosux%', $char ) ) {
+                                if ( false === strpos( 'bcdefgosux%l', $char ) ) {
                                         $unexpected_tokens[] = $m[0][ $i ];
                                 }
@@ -312 +312 @@
                 // https://github.com/GlotPress/GlotPress-WP/pull/1237
                 add_filter( 'gp_warning_placeholders_re', function( $re ) {
-                        if ( '%(\d+\$(?:\d+)?)?[bcdefgosuxEFGX]' === $re ) {
-                                $re = '(?<!%)%(\d+\$(?:\d+)?)?[bcdefgosuxEFGX%]';
+                        if ( '%(\d+\$(?:\d+)?)?[bcdefgosuxEFGXl]' === $re ) {
+                                $re = '(?<!%)%(\d+\$(?:\d+)?)?[bcdefgosuxEFGX%l]';
                         }
                         return $re;