Changeset 11026

Timestamp:

06/11/2021 05:48:08 AM (3 years ago)

Author:

dd32

Message:

Search: Ensure that all appropriate variables are predefined to cover all cases.

Follow up to [11025].
See #5771.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/searchform.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/searchform.php

@@ -17 +17 @@
     <label for="s" class="screen-reader-text"><?php _ex( 'Search for:', 'label', 'wporg-forums' ); ?></label>
     <?php
-        $tab = null;
+        $placeholder = _x( 'Search forums', 'placeholder', 'wporg-forums' );
+        $project     = false;
+        $tab         = 'support';
+
         if ( in_array( current_action(), [ 'bbp_template_before_pagination_loop', 'wporg_compat_before_single_view' ] ) ) {
             $placeholder = _x( 'Search this forum', 'placeholder', 'wporg-forums' );
@@ -25 +28 @@
         } elseif ( is_front_page() ) {
             $placeholder = _x( 'Search documentation', 'placeholder', 'wporg-forums' );
-            $project     = null;
             $tab         = 'docs';
         } elseif ( is_search() || bbp_is_search() ) {
-            if ( isset( $_GET['tab'] ) ) {
+            if ( !empty( $_GET['tab'] ) ) {
                 $tab     = $_GET['tab'];
                 $project = $_GET[ $_GET['tab'] ];
             }
-        } else {
-            $placeholder = _x( 'Search forums', 'placeholder', 'wporg-forums' );
-            $project     = null;
-            $tab         = 'support';
         }
     ?>