Changeset 11038

Timestamp:

06/18/2021 04:26:50 AM (4 years ago)

Author:

dd32

Message:

Theme Directory: When logging theme upload failures to slack, use a more visible :x: icon for the message.

Also uses a nicer class name for when a check class is namespaced.

See #5702.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -1413 +1413 @@
                 $error = $check->getError();
 
-                $class = get_class( $check );
+                // Account for namespaces by getting the short name.
+                $class = (new \ReflectionClass( $check ))->getShortName();
 
                 // Humanize the class name.
@@ -1543 +1544 @@
         $send = new \Dotorg\Slack\Send( THEME_DIRECTORY_SLACK_WEBHOOK );
         $send->add_attachment( [ 'blocks' => $blocks ] );
-        $send->set_username( 'allowed' === $status ? 'Theme Upload' : 'Theme Check Blocked' );
-        $send->set_icon( ':themes:' );
+
+        if ( 'allowed' === $status ) {
+            $send->set_username( 'Theme Upload' );
+            $send->set_icon( ':themes:' );
+        } else {
+            $send->set_username( 'Theme Check Blocked Upload' );
+            $send->set_icon( ':x:' );
+        }
+
         $send->send( '#themereview-firehose' );
     }