Changeset 11068

Timestamp:

06/26/2021 02:07:54 PM (4 years ago)

Author:

ocean90

Message:

Translate, Plugin Directory: During translation sync also discard warnings for existing translations.

Fixes #3828.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/sync/class-translation-sync.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/sync/class-translation-sync.php

@@ -244 +244 @@
 
             if ( $existing_translation === $new_translation ) {
+                // Translations are only synced if they have no warnings.
+                // If the existing translation still has warnings discard them automatically.
+                if ( $_existing_translation->warnings ) {
+                    $_existing_translation->warnings = null;
+                    $_existing_translation->save();
+                }
+
                 $_existing_translation->set_as_current();
                 gp_clean_translation_set_cache( $new_translation_set->id );
@@ -251 +258 @@
         }
 
+        // Create a new translation.
         $copy = new GP_Translation( $translation->fields() );
         $copy->original_id = $new_original->id;