Changeset 11081

Timestamp:

06/30/2021 12:25:52 AM (5 years ago)

Author:

dd32

Message:

Login: URIEncode emails/usernames in the HTTP request to preserve all characters.

Follow up to r11073

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login

Files:

• functions-restapi.php (modified) (2 diffs)
• functions.php (modified) (1 diff)
• js/registration.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/functions-restapi.php

@@ -33 +33 @@
 
 function wporg_login_rest_username_exists( $request ) {
-    $login = trim( $request['login'] );
+    $login = trim( urldecode( $request['login'] ) );
 
     $validate_signup = wpmu_validate_user_signup( $login, 'placeholder@placeholder.domain' );
@@ -73 +73 @@
 
 function wporg_login_rest_email_in_use( $request ) {
-    $email = trim( $request['email'] );
+    $email = trim( urldecode( $request['email'] ) );
 
     if ( $user = get_user_by( 'email', $email ) ) {

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/functions.php

@@ -98 +98 @@
     );
 
-    wp_register_script( 'wporg-registration', get_template_directory_uri() . '/js/registration.js', array( 'recaptcha-api', 'jquery' ), '20210517' );
+    wp_register_script( 'wporg-registration', get_template_directory_uri() . '/js/registration.js', array( 'recaptcha-api', 'jquery' ), filemtime( __DIR__ . '/js/registration.js' ) );
     wp_localize_script( 'wporg-registration', 'wporg_registration', array(
         'rest_url' => esc_url_raw( rest_url( 'wporg/v1' ) )

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/js/registration.js

@@ -17 +17 @@
                 var rest_url = wporg_registration.rest_url +
                     ( this.id == 'user_login' ? '/username-available/' : '/email-in-use/' ) +
-                    $this.val();
+                    encodeURIComponent( $this.val() );
 
                 $.get( rest_url, function( datas ) {