Changeset 11083

Timestamp:

07/01/2021 12:19:51 AM (3 years ago)

Author:

dd32

Message:

Support Forums: Revert to using the global WordPress.org/search system rather than using bbPress/WordPress search.

Reverts [11025], [11026], [11027].
See #5771.

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

• plugins/support-forums/inc/class-performance-optimizations.php (modified) (3 diffs)
• themes/pub/wporg-support/bbpress/loop-search.php (modified) (1 diff)
• themes/pub/wporg-support/search.php (deleted)
• themes/pub/wporg-support/searchform.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php

@@ -32 +32 @@
 
         // Redirect search results.
-        add_action( 'bbp_template_redirect', array( $this, 'redirect_search_results' ) );
-        add_filter( 'pre_get_posts', array( $this, 'search_alterations' ) );
-        add_filter( 'pre_get_posts', array( $this, 'search_forum_alterations' ) );
-        add_filter( 'bbp_after_has_search_results_parse_args', array( $this, 'search_forum_alteration_args' ) );
+        add_action( 'bbp_template_redirect', array( $this, 'redirect_search_results_to_google_search' ) );
 
         // Redirect (.+)/page/[01]/ and (.+)?paged=[01] to $1
@@ -80 +77 @@
 
     /**
-     * Redirects search results to appropriate place.
-     */
-    public function redirect_search_results() {
-        if ( ! is_search() ) {
+     * Redirects search results to Google Custom Search.
+     */
+    public function redirect_search_results_to_google_search() {
+        $is_wp_search  = is_search();
+        $is_bbp_search = bbp_is_search_results();
+
+        if ( ! $is_wp_search && ! $is_bbp_search ) {
             return;
         }
@@ -91 +91 @@
         }
 
-        $search_terms = get_search_query( false );
-
-        $tab = $_GET['tab'] ?? 'support';
-        if ( ! in_array( $tab, [ 'support', 'docs', 'plugin', 'theme', 'searchforum' ] ) ) {
-            $tab = 'support';
-        }
-
-        switch ( $tab ) {
-            case 'theme':
-            case 'plugin':
-            case 'searchforum':
-                wp_safe_redirect( add_query_arg( $tab, $_GET[ $tab ], home_url( "/search/{$search_terms}/" ) ) );
-                exit;
-            case 'support':
-                wp_safe_redirect( home_url( "/search/{$search_terms}/" ) );
-                exit;
-            case 'docs':
-                // Do nothing.
-        }
-    }
-
-    /**
-     * Search alterations for forums.
-     */
-    public function search_alterations( $query ) {
-        if ( ! is_search() || ! $query->is_search() ) {
-            return;
-        }
-
-        $query->set( 'post_type', [ 'page', 'helphub_article' ] );
-
-    }
-
-    public function search_forum_alterations( $query ) {
-        if ( empty( $query->query['_bbp_search_query'] ) ) {
-            return;
-        }
-
-        // Limit searches to published topics.
-        $query->set( 'post_type', 'topic' );
-        $query->set( 'post_status', 'publish' );
-
-        // Limit to either the plugin/theme in question, or to general support threads.
-        if ( !empty( $_GET['plugin'] ) ) {
-            $query->set( 'tax_query', [
-                [
-                    'taxonomy' => 'topic-plugin',
-                    'field' => 'slug',
-                    'terms' => [ $_GET['plugin'] ]
-                ]
-            ] );
-
-            add_filter( 'posts_where', array( $this, 'posts_in_last_year' ) );
-        } elseif ( ! empty( $_GET['theme'] ) ) {
-            $query->set( 'tax_query', [
-                [
-                    'taxonomy' => 'topic-theme',
-                    'field' => 'slug',
-                    'terms' => [ $_GET['theme'] ]
-                ]
-            ] );
-
-            add_filter( 'posts_where', array( $this, 'posts_in_last_year' ) );
-        } elseif ( ! empty( $_GET['searchforum'] ) ) {
-            $query->set( 'post_parent', (int) $_GET['searchforum'] );
-
-            add_filter( 'posts_where', array( $this, 'posts_in_last_year' ) );
-        } else {
-            $query->set( 'post_parent__not_in', [21261, 21262, 21272] ); // Magic numbers: Plugins, Themes, Reviews
-
-            add_filter( 'posts_where', array( $this, 'posts_in_last_six_months' ) );
-        }
-    }
-
-    public function search_forum_alteration_args( $args ) {
-        $args['_bbp_search_query'] = true;
-
-        return $args;
+        $search_terms = $search_url = '';
+
+        if ( $is_bbp_search ) {
+            $search_terms = bbp_get_search_terms();
+        } elseif ( $is_wp_search ) {
+            $search_terms = get_search_query( false );
+        }
+
+        if ( isset( $_GET['intext'] ) ) {
+            $search_terms .= ' intext:"' . esc_attr( $_GET['intext'] ) . '"';
+        }
+
+        if ( $search_terms ) {
+            $tab = ! empty( $_GET['tab'] ) && 'docs' === $_GET['tab'] ? 'docs' : 'forums';
+            $search_url = sprintf( "https://wordpress.org/search/%s/?{$tab}=1", urlencode( $search_terms ) );
+            $search_url = esc_url_raw( $search_url );
+        }
+
+        if ( ! $search_url ) {
+            wp_safe_redirect( home_url( '/' ) );
+            exit;
+        }
+
+        wp_safe_redirect( $search_url );
+        exit;
     }
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/bbpress/loop-search.php

@@ -9 +9 @@
             <?php if ( 'topic' === get_post_type() ) : ?>
 
-                <?php bbp_get_template_part( 'loop', 'single-topic' ); ?>
+                <?php bbp_get_template_part( 'content', 'single-topic-lead' ); ?>
 
             <?php else : ?>

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/searchform.php

@@ -17 +17 @@
     <label for="s" class="screen-reader-text"><?php _ex( 'Search for:', 'label', 'wporg-forums' ); ?></label>
     <?php
-        $placeholder = _x( 'Search forums', 'placeholder', 'wporg-forums' );
-        $project     = false;
-        $tab         = 'support';
-
+        $tab = null;
         if ( in_array( current_action(), [ 'bbp_template_before_pagination_loop', 'wporg_compat_before_single_view' ] ) ) {
             $placeholder = _x( 'Search this forum', 'placeholder', 'wporg-forums' );
             $project     = wporg_support_get_compat_object();
-            if ( $project ) {
-                $tab     = $project->type;
-                $project = $project->post_name;
-            } else {
-                // Specific forum.
-                $tab     = 'searchforum';
-                $project = bbp_get_forum_id();
-            }
         } elseif ( is_front_page() ) {
             $placeholder = _x( 'Search documentation', 'placeholder', 'wporg-forums' );
+            $project     = null;
             $tab         = 'docs';
-        } elseif ( is_search() || bbp_is_search() ) {
-            if ( !empty( $_GET['tab'] ) ) {
-                $tab     = $_GET['tab'];
-                $project = $_GET[ $_GET['tab'] ] ?? '';
-            }
+        } else {
+            $placeholder = _x( 'Search forums', 'placeholder', 'wporg-forums' );
+            $project     = null;
         }
     ?>
-    <input type="search" id="s" class="search-field" placeholder="<?php echo esc_attr( $placeholder ); ?>" value="<?php echo esc_attr( get_query_var( 's' ) ?: get_query_var( 'bbp_search' ) ) ?>" name="s" />
+    <input type="search" id="s" class="search-field" placeholder="<?php echo esc_attr( $placeholder ); ?>" value="<?php the_search_query(); ?>" name="s" />
     <?php if ( $project ) : ?>
-    <input type="hidden" name="<?php echo esc_attr( $tab ); ?>" value="<?php echo esc_attr( $project ); ?>" />
+    <input type="hidden" name="intext" value="<?php echo esc_attr( $project->prefixed_title ); ?>" />
     <?php endif; ?>
     <?php if ( $tab ) : ?>