Changeset 11093

Timestamp:

07/05/2021 07:39:12 PM (3 years ago)

Author:

ocean90

Message:

Translate: Prevent querying the translation memory for long and too unique strings which are not returning results.

Fixes #5804.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/inc

Files:

• class-plugin.php (modified) (1 diff)
• class-translation-memory-client.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/inc/class-plugin.php

@@ -147 +147 @@
         }
 
+
+        // Prevent querying the TM for long strings which usually time out
+        // and have no results due to being too unique.
+        $query_tm = mb_strlen( $entry->singular ) <= 420;
+
         ?>
-        <details open class="suggestions__translation-memory" data-nonce="<?php echo esc_attr( wp_create_nonce( 'translation-memory-suggestions-' . $entry->original_id ) ); ?>">
+        <details open class="suggestions__translation-memory<?php echo $query_tm ? '' : ' initialized'; ?>" data-nonce="<?php echo esc_attr( wp_create_nonce( 'translation-memory-suggestions-' . $entry->original_id ) ); ?>">
             <summary>Suggestions from Translation Memory</summary>
-            <p class="suggestions__loading-indicator">Loading <span aria-hidden="true" class="suggestions__loading-indicator__icon"><span></span><span></span><span></span></span></p>
+            <?php if ( $query_tm ) : ?>
+                <p class="suggestions__loading-indicator">Loading <span aria-hidden="true" class="suggestions__loading-indicator__icon"><span></span><span></span><span></span></span></p>
+            <?php else : ?>
+                <p class="no-suggestions">No suggestions.</p>
+            <?php endif; ?>
         </details>
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/inc/class-translation-memory-client.php

@@ -112 +112 @@
             $url,
             [
-                'timeout'    => 2,
+                'timeout'    => 4,
                 'user-agent' => 'WordPress.org Translate',
             ]