Changeset 11096 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/block-json/class-validator.php

Timestamp:

07/06/2021 08:33:03 PM (3 years ago)

Author:

ryelle

Message:

Plugin Directory: Remove "style" requirement when validating block plugins.

Previously, either editorStyle or style was required for block plugins, but this was not communicated to the plugin developer (only as a recommendation). This caused some block plugins to pass the validation in UI, but still fail validation behind the scenes. Omitting a style doesn't break anything on the core side, so it should be allowed.

Props oskosk for flagging an affected block.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/block-json/class-validator.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/block-json/class-validator.php

@@ -234 +234 @@
             $this->append_error_data( 'block.json:script', 'error' );
             $this->append_error_data( 'block.json:editorScript', 'error' );
-        }
-
-        if ( ! isset( $block_json->style ) && ! isset( $block_json->editorStyle ) ) {
-            $this->messages->add(
-                'error',
-                sprintf(
-                    __( 'At least one of the following properties must be present: %s', 'wporg-plugins' ),
-                    // translators: used between list items, there is a space after the comma.
-                    '<code>style</code>' . __( ', ', 'wporg-plugins' ) . '<code>editorStyle</code>'
-                )
-            );
-            $this->append_error_data( 'block.json:style', 'error' );
-            $this->append_error_data( 'block.json:editorStyle', 'error' );
         }
     }