Changeset 11103

Timestamp:

07/07/2021 10:14:09 PM (5 years ago)

Author:

iandunn

Message:

Patterns API: Test for valid response before accessing body.

Previously tests would fail with unclear error message when the response was a 500 error. This makes it obvious what the problem is.

File:

• sites/trunk/api.wordpress.org/public_html/patterns/1.0/tests/test-index.php (modified) (6 diffs)

sites/trunk/api.wordpress.org/public_html/patterns/1.0/tests/test-index.php

@@ -15 +15 @@
      */
     public function assertResponseHasPattern( $response ) {
+        $this->assertSame( 200, $response->status_code );
+
         $patterns = json_decode( $response->body );
-
-        $this->assertSame( 200, $response->status_code );
         $this->assertGreaterThan( 0, count( $patterns ) );
         $this->assertIsString( $patterns[0]->title->rendered );
@@ -51 +51 @@
      */
     public function test_browse_all_patterns() : void {
-        $response   = send_request( '/patterns/1.0/' );
+        $response = send_request( '/patterns/1.0/' );
+        $this->assertResponseHasPattern( $response );
+
         $patterns   = json_decode( $response->body );
         $term_slugs = $this->get_term_slugs( $patterns );
-
-        $this->assertResponseHasPattern( $response );
         $this->assertGreaterThan( 1, count( $term_slugs ) );
     }
@@ -67 +67 @@
         $button_term_id = 2;
         $response       = send_request( '/patterns/1.0/?pattern-categories=' . $button_term_id );
-        $patterns       = json_decode( $response->body );
-        $term_slugs     = $this->get_term_slugs( $patterns );
-
         $this->assertResponseHasPattern( $response );
+
+        $patterns   = json_decode( $response->body );
+        $term_slugs = $this->get_term_slugs( $patterns );
         $this->assertSame( array( 'buttons' ), $term_slugs );
     }
@@ -98 +98 @@
 
         $response = send_request( $query_args );
-
         $this->assertResponseHasPattern( $response );
 
@@ -104 +103 @@
         $found_locales = array_column( $patterns, 'meta' );
         $found_locales = array_column( $found_locales, 'wpop_locale' );
-
-        $this->assertSame( 200, $response->status_code );
 
         if ( $expected_locale ) {
@@ -198 +195 @@
      */
     public function test_browse_all_categories() : void {
-        $response   = send_request( '/patterns/1.0/?categories' );
+        $response = send_request( '/patterns/1.0/?categories' );
+        $this->assertSame( 200, $response->status_code );
+
         $categories = json_decode( $response->body );
-
-        $this->assertSame( 200, $response->status_code );
         $this->assertGreaterThan( 0, count( $categories ) );
-
         $this->assertIsInt( $categories[0]->id );
         $this->assertIsString( $categories[0]->name );