Changeset 11106

Timestamp:

07/08/2021 12:10:57 AM (4 years ago)

Author:

iandunn

Message:

Patterns API: Wrap search term in double quotes to match exact phrase.

The stripos return was switched to false, since a valid value of 0 could trigger a false negative.

File:

• sites/trunk/api.wordpress.org/public_html/patterns/1.0/tests/test-index.php (modified) (2 diffs)

sites/trunk/api.wordpress.org/public_html/patterns/1.0/tests/test-index.php

@@ -153 +153 @@
      */
     public function test_search_patterns( $search_term, $match_expected ) : void {
-        $response = send_request( '/patterns/1.0/?&search=' . $search_term . '&pattern-keywords=11&locale=en_US' );
+        // wrap term in double quotes to match exact phrase.
+        $response = send_request( '/patterns/1.0/?&search="' . $search_term . '"&pattern-keywords=11&locale=en_US' );
 
         if ( $match_expected ) {
@@ -163 +164 @@
             foreach ( $patterns as $pattern ) {
                 $match_in_title       = stripos( $pattern->title->rendered, $search_term );
-                $match_in_description = stripos( $pattern->meta->wpop_description, $search_term );;
-
-                if ( ! $match_in_title && ! $match_in_description ) {
+                $match_in_description = stripos( $pattern->meta->wpop_description, $search_term );
+
+                if ( false === $match_in_title && false === $match_in_description ) {
                     $all_patterns_include_query = false;
                     break;