Changeset 11175 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/rest-api/class-themes-auto-review.php

Timestamp:

08/12/2021 06:54:30 AM (5 years ago)

Author:

dd32

Message:

Theme Directory: Guard against undefined constants closer to where they're used.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/rest-api/class-themes-auto-review.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/rest-api/class-themes-auto-review.php

@@ -124 +124 @@
          */
         public function update_item( $request ) {
+                if ( ! defined( 'THEME_TRACBOT_PASSWORD' ) || ! THEME_TRACBOT_PASSWORD ) {
+                        return new \WP_Error(
+                                'rest_error_updating_ticket',
+                                __( 'Unable to locate ticket.', 'wporg-themes' ),
+                                array( 'status' => \WP_Http::INTERNAL_SERVER_ERROR )
+                        );
+                }
+
                 if ( ! class_exists( 'Trac' ) ) {
                         require_once ABSPATH . WPINC . '/class-IXR.php';
@@ -137 +145 @@
                 $ticket = $trac_instance->ticket_get( $ticket_id );
 
-                if( ! $ticket ){
+                if ( ! $ticket ) {
                         return new \WP_Error(
                                 'rest_invalid_ticket',
@@ -147 +155 @@
                 $body = $request->get_body();
 
-                if( empty( $body ) ) {
+                if ( empty( $body ) ) {
                         return new \WP_Error(
                                 'rest_error_updating_ticket',
@@ -159 +167 @@
                 $updated_ticket = $trac_instance->ticket_update( $ticket_id, $content, [], false );
 
-                if( ! $updated_ticket ) {
+                if ( ! $updated_ticket ) {
                         return new \WP_Error(
                                 'rest_error_updating_ticket',