Changeset 11186

Timestamp:

08/18/2021 03:23:46 PM (4 years ago)

Author:

iandunn

Message:

Patterns: Use explicit pass/fail for clarity.

File:

• sites/trunk/api.wordpress.org/public_html/patterns/1.0/tests/test-index.php (modified) (3 diffs)

sites/trunk/api.wordpress.org/public_html/patterns/1.0/tests/test-index.php

@@ -18 +18 @@
 
         $patterns = json_decode( $response->body );
+        $this->assertIsArray( $patterns );
         $this->assertGreaterThan( 0, count( $patterns ) );
         $this->assertIsString( $patterns[0]->title->rendered );
@@ -32 +33 @@
      */
     public function assertAllPatternsMatchSearchTerm( $patterns, $search_term ) {
-        $all_patterns_include_query = true;
         if ( false !== strpos( $search_term, ' ' ) ) {
             $this->markTestIncomplete( "This doesn't support phrase-matching quoted terms yet." );
@@ -42 +42 @@
 
             if ( false === $match_in_title && false === $match_in_description ) {
-                $all_patterns_include_query = false;
-                break;
+                $this->fail( "`$search_term` not found in `{$pattern->title->rendered}` pattern (ID {$pattern->id})" );
             }
         }
 
-        $this->assertTrue( $all_patterns_include_query );
+        $this->pass();
+    }
+
+    /**
+     * PHPUnit provides `fail()`, but no equivalent for success. This makes calling code more obvious and self-documenting.
+     */
+    public function pass() {
+        $this->assertTrue( true );
     }