Changeset 11201

Timestamp:

08/25/2021 06:58:32 AM (3 years ago)

Author:

dd32

Message:

Slack: Use the centralised $committers committers definition so as not to duplicate user lists in multiple places.

See #5870.

File:

• sites/trunk/common/includes/slack/announce/config.php (modified) (2 diffs)

sites/trunk/common/includes/slack/announce/config.php

@@ -18 +18 @@
  *  - Private groups do NOT need to be listed here. All members of a private group can use announcements.
  *  - Sub-channels inherit access, if a user is granted announce in #foo, they can also announce in #foo-bar.
+ *  - Committers have access to `#core` and all sub-channels. The list comes from the global `$committers` configuration.
  */
 function get_whitelist() {
@@ -449 +450 @@
 }
 
+/**
+ * Fetch a list of the WordPress core committers.
+ * 
+ * This is defined on WordPress.org in a global variable called `$committers`.
+ * It's defined as part of the configuration bootstrap.
+ */
 function get_committers() {
-    return array(
-        'aaroncampbell', 'adamsilverstein', 'aduth', 'afercia', 'allancole', 'allendav',
-        'antpb', 'atimmer', 'azaozz', 'bpayton', 'Clorith', 'davidbaumwald', 'dd32', 'desrosj',
-        'DrewAPicture', 'ellatrix', 'flixos90', 'gziolo', 'helen', 'herregroen', 'ianbelanger',
-        'iandunn', 'joedolson', 'joemcgill', 'joen', 'johnbillion', 'johnjamesjacoby', 'jorbin',
-        'jorgefilipecosta', 'jrf', 'karmatosed', 'laurelfulford', 'matt', 'matveb', 'mcsf', 'melchoyce',
-        'michaelarestad', 'mikeschroder', 'nacin', 'noisysocks', 'ocean90', 'omarreiss', 'pento',
-        'peterwilsoncc', 'rachelbaker', 'ryelle', 'SergeyBiryukov', 'swissspidy', 'talldanwp', 'tellyworth',
-        'TimothyBlynJacobs', 'westi', 'westonruter', 'whyisjake', 'williampatton', 'xknown', 'youknowriad',
-
-    );
+    global $committers;
+
+    if ( empty( $committers ) ) {
+        return array();
+    }
+
+    return array_keys( $committers );
 }