Changeset 11242

Timestamp:

09/17/2021 01:59:58 AM (5 years ago)

Author:

dd32

Message:

Comment Moderation: Exclude links to ​https://github.com/WordPress/* as part of the link count in comments.

This makes it easier for the Core/Editor teams to reference GitHub issues in weekly posts.

This commit also tightens the URL matching, to avoid potential workarounds where a url 'contains' a whitelisted url, but isn't that url.

See ​https://wordpress.slack.com/archives/C02QB8GMM/p1631707101032800

File:

• sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/comment-moderation.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/comment-moderation.php

@@ -23 +23 @@
 
         // Get whitelisted URLs.
-        // Note: unnecessary to specify subdomains
+        // Note: unnecessary to specify subdomains, do not include trailing slash.
         $whitelist_urls = array(
                 'wordpress.org',
+                'github.com/WordPress',
         );
 
@@ -60 +61 @@
 
                 // Count the number of occurrences of this particular whitelisted URL.
-                $num_whitelist_links = preg_match_all( '%<a [^>]*href=[\'\"]https?://[^/>]*' . preg_quote( $url, '%' ) . '%i', $comment, $out );
+                $num_whitelist_links = preg_match_all( '%<a [^>]*href=([\'\"])https?://([^/>]+\.)?' . preg_quote( $url, '%' ) . '(/|\\1)%i', $comment, $out );
 
                 // Increase the limit by the number of whitelisted URLs (so that they don't