Changeset 11287

Timestamp:

10/20/2021 11:29:48 PM (3 years ago)

Author:

dd32

Message:

Support Forums: Make the forum search work for plugins that use pipe characters in their plugin name.

This may cause plugins to match other plugins with a similar plugin title prefix, but this is better than returning zero items.

This causes a plugin title such as 'Super Magical | Great Thing!' to simply search for all plugin threads for plugin titles starting with 'Super Magical'.

Props paapst.
Fixes #5932.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/functions.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-support/functions.php

@@ -497 +497 @@
 
         /* translators: %s: link to plugin support or review forum */
-        $object->prefixed_title = sprintf( __( 'Plugin: %s', 'wporg-forums' ), $object->post_title );
-        $object->type           = 'plugin';
+        $object->search_prefix = sprintf( __( 'Plugin: %s', 'wporg-forums' ), $object->post_title );
+        $object->type          = 'plugin';
     } elseif ( ! empty( $plugin_instance->themes->theme ) ) {
         $object = $plugin_instance->themes->theme;
 
         /* translators: %s: link to theme support or review forum */
-        $object->prefixed_title = sprintf( __( 'Theme: %s', 'wporg-forums' ), $object->post_title );
-        $object->type           = 'theme';
+        $object->search_prefix = sprintf( __( 'Theme: %s', 'wporg-forums' ), $object->post_title );
+        $object->type          = 'theme';
+    }
+
+    // The search prefix must be sans any special characters.
+    // This may cause some plugins to match other plugins of similar prefixed names.
+    if ( ! empty( $object->search_prefix ) ) {
+        $search_special_chars  = '|';
+        $object->search_prefix = rtrim( strtok( $object->search_prefix, $search_special_chars ) );
     }