Changeset 11304

Timestamp:

11/02/2021 07:15:12 AM (4 years ago)

Author:

dd32

Message:

Theme Directory: Slack Firehose: When a theme import came from SVN, include a 'Compare' link along side the changeset, as the changeset diff is unlikely to show the changes directly.

See #5899.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -131 +131 @@
      */
     protected $version_status = 'new';
+
+    /**
+     * Where the import is triggered from. 'svn' or 'upload'.
+     * 
+     * @var string
+     */
+    protected $importing_from = 'upload';
 
     /**
@@ -169 +176 @@
         );
         $this->version_status = 'new';
+        $this->importing_from = 'upload';
 
         // $this->tmp_dir = '';    // Temporary folder per each instance of this class. Doesn't need to be reset each time.
@@ -217 +225 @@
         $this->reset_properties();
 
-        $this->theme_slug = $slug;
+        $this->importing_from = 'svn';
+        $this->theme_slug     = $slug;
 
         // Check out from SVN.
@@ -1743 +1752 @@
                         (
                             $this->trac_changeset ?
-                            "<https://themes.trac.wordpress.org/changeset/{$this->trac_changeset}|[{$this->trac_changeset}]>" :
+                            "<https://themes.trac.wordpress.org/changeset/{$this->trac_changeset}|[{$this->trac_changeset}]> " :
+                            ''
+                        ) . 
+                        (
+                            // When importing from SVN, include a 'Compare' link as the Changeset likely won't show a Diff unless the author did a `svn cp`.
+                            'svn' === $this->importing_from && ! empty( $this->theme_post->max_version ) ?
+                            "<https://themes.trac.wordpress.org/changeset?old_path={$this->theme_slug}/{$this->theme_post->max_version}&new_path={$this->theme_slug}/{$this->theme->display( 'Version' )}|Compare>" :
                             ''
                         ),