Changeset 11348

Timestamp:

11/30/2021 10:27:12 PM (3 years ago)

Author:

Ipstenu

Message:

Update the various checkers for restricted terms in plugins

Explain why terms are blocked in a less trademarky fashion

Attempting to block 'woopress' submissions

Fixes #5969

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php (modified) (15 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php

@@ -116 +116 @@
         // Make sure it doesn't use a TRADEMARK protected slug.
         if ( false !== $this->has_trademarked_slug() ) {
-            $error = __( 'Error: The plugin includes a trademarked name.', 'wporg-plugins' );
+            $error = __( 'Error: The plugin name includes a restricted term.', 'wporg-plugins' );
 
             if ( $this->has_trademarked_slug() === trim( $this->has_trademarked_slug(), '-' ) ) {
@@ -122 +122 @@
                 $message = sprintf(
                     /* translators: 1: plugin slug, 2: trademarked term, 3: 'Plugin Name:', 4: plugin email address */
-                    __( 'Your chosen plugin name - %1$s - contains the restricted term "%2$s" and cannot be used at all in your plugin permalink nor the display name. To proceed with this submission you must remove "%2$s" from the %3$s line in both your main plugin file and readme entirely. Once you\'ve finished, you may upload the plugin again. Do not attempt to work around this by removing letters (i.e. WordPess) or using numbers (4 instead of A). Those are seen as intentional actions to avoid trademark laws, and are not permitted. If you feel this is in error, such as you legally own the trademarked term, please email us at %4$s and explain why.', 'wporg-plugins' ),
+                    __( 'Your chosen plugin name - %1$s - contains the restricted term "%2$s" and cannot be used at all in your plugin permalink nor the display name. To proceed with this submission you must remove "%2$s" from the %3$s line in both your main plugin file and readme entirely. Once you\'ve finished, you may upload the plugin again. Do not attempt to work around this by removing letters (i.e. WordPess) or using numbers (4 instead of A). Those are seen as intentional actions to avoid our restrictions, and are not permitted. If you feel this is in error, such as you legally own the trademark for a term, please email us at %4$s and explain your situation.', 'wporg-plugins' ),
                     '<code>' . $this->plugin_slug . '</code>',
                     trim( $this->has_trademarked_slug(), '-' ),
@@ -132 +132 @@
                 $message = sprintf(
                     /* translators: 1: plugin slug, 2: trademarked term, 3: 'Plugin Name:', 4: plugin email address */
-                    __( 'Your chosen plugin name - %1$s - contains the restricted term "%2$s" and cannot be used to begin your permalink or display name. Per the requirements of trademark owners and law, we disallow the use of certain terms in ways that are infringing and/or misleading. In order to proceed with this submission, you must change the %3$s line in your main plugin file and readme to end with  "-%2$s" instead. Once you\'ve finished, you may upload the plugin again. If you feel this is in error, such as you legally own the trademarked term, please email us at %4$s and explain why.', 'wporg-plugins' ),
+                    __( 'Your chosen plugin name - %1$s - contains the restricted term "%2$s" and cannot be used to begin your permalink or display name. We disallow the use of certain terms in ways that are abused, or potentially infringe on and/or are misleading with regards to trademarks. In order to proceed with this submission, you must change the %3$s line in your main plugin file and readme to end with  "-%2$s" instead. Once you\'ve finished, you may upload the plugin again. If you feel this is in error, such as you legally own the trademark for the term, please email us at %4$s and explain your situation.', 'wporg-plugins' ),
                     '<code>' . $this->plugin_slug . '</code>',
                     trim( $this->has_trademarked_slug(), '-' ),
@@ -366 +366 @@
         ) . '</p><p>';
 
-        $message .= __( 'If there are any errors in your submission, please email us as soon as possible. We can correct many issues before approval.', 'wporg-plugins' ) . '</p><p>';
+        $message .= __( 'If there are any errors in your submission, such as having submitted via the wrong account, please don\'t resubmit! Instead, email us as soon as possible (you can reply to the automated email we sent you). We can correct most issues before approval.', 'wporg-plugins' ) . '</p><p>';
 
         $message .= sprintf(
@@ -376 +376 @@
 
         $message .= __( 'Note: Reviews are currently in English only. We apologize for the inconvenience.', 'wporg-plugins' );
+
+        $message .= '</p>';
 
         // Success!
@@ -445 +447 @@
             'apple-',
             'applenews-',
+            'applepay-',
             'aws-',
+            'azon-',
             'bbpress-',
             'bing-',
+            'booking-com',
             'bootstrap-',
             'buddypress-',
             'contact-form-7-',
+            'cloudflare-',
             'cpanel-',
             'disqus-',
@@ -464 +470 @@
             'fedex-',
             'feedburner',
+            'firefox-',
+            'fontawesome-',
+            'font-awesome-',
             'ganalytics-',
             'gberg',
@@ -473 +482 @@
             'gravity-form-',
             'gravity-forms-',
+            'gravityforms-',
+            'gtmetrix-',
             'gutenberg',
             'guten-',
@@ -480 +491 @@
             'instagram',
             'internet-explorer-',
+            'ios-',
             'jetpack-',
             'macintosh-',
+            'macos-',
             'mailchimp-',
             'microsoft-',
@@ -488 +501 @@
             'onlyfans-',
             'only-fans-',
+            'opera-',
             'paddle-',
             'paypal-',
             'pinterest-',
+            'plugin',
+            'skype-',
             'stripe-',
             'tiktok-',
+            'tik-tok-',
             'trustpilot',
+            'twitch-',
             'twitter-',
             'tweet',
@@ -503 +521 @@
             'vvoo',
             'wa-',
+            'webpush-vn',
             'wh4tsapps',
             'whatsapp',
@@ -524 +543 @@
             'yoast',
             'youtube-',
+            'you-tube-',
         );
 
@@ -535 +555 @@
             'microsoft.com'         => array( 'bing-', 'microsoft-' ),
             'yandex-team.ru'        => array( 'yandex' ),
+            'opera.com'             => array( 'opera-' ),
         );
 
@@ -540 +561 @@
         $for_use_exceptions = array(
             'woocommerce',
+        );
+
+        // Commonly used 'combo' names (to prevent things like 'woopress').
+        $portmanteaus = array(
+            'woo',
         );
 
@@ -568 +594 @@
         }
 
+        // Check portmanteaus.
+        foreach ( $portmanteaus as $portmanteau ) {
+            if ( 0 === strpos( $this->plugin_slug, $portmanteau ) ) {
+                $has_trademarked_slug = $portmanteau;
+                break;
+            }
+        }
+
         // Get the user email domain.
         list( ,$user_email_domain ) = explode( '@', wp_get_current_user()->user_email, 2 );