Changeset 11350 for sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php

Timestamp:

12/01/2021 05:40:03 AM (3 years ago)

Author:

dd32

Message:

Support Forums: Check that the topic date was parseable before using the resulting DateTime object, to avoid a PHP Fatal error on topic-less replies.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-hooks.php

@@ -1262 +1262 @@
         $last_active = get_post_meta( $topic_id, '_bbp_last_active_time', true );
         if ( empty( $last_active ) ) {
-            if ( ! empty( $reply_id ) ) {
-                $last_active = get_post_field( 'post_date', $reply_id );
-            } else {
-                $last_active = get_post_field( 'post_date', $topic_id );
-            }
+            $last_active = get_post_field( 'post_date', $topic_id );
         }
 
         // This is for translating the date components.
         $datetime = date_create_immutable_from_format( 'Y-m-d H:i:s', $last_active );
-        $date     = wp_date( get_option( 'date_format' ), $datetime->getTimestamp() );
-        $time     = wp_date( get_option( 'time_format' ), $datetime->getTimestamp() );
+        if ( ! $datetime ) {
+            return $anchor;
+        }
+
+        $date = wp_date( get_option( 'date_format' ), $datetime->getTimestamp() );
+        $time = wp_date( get_option( 'time_format' ), $datetime->getTimestamp() );
 
         return str_replace(