Changeset 11371 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-trac-watcher/trac.php

Timestamp:

12/15/2021 02:47:05 AM (5 years ago)

Author:

dd32

Message:

SVN Watcher: Some performance improvements for the admin view & reports.

This reduces the queries by removing oEmbed processing of commit messages, caching users in bulk, avoiding PHP Notices, documenting some things, skipping the UI if revisions/props aren't imported for a SVN.

See #5978.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-trac-watcher/trac.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-trac-watcher/trac.php

@@ -8 +8 @@
 function format_trac_markup( $message ) {
         $message = esc_html( $message );
+
+        // Convert some Trac markdown to HTML.
         $message = preg_replace( '!`(.*?)`!i', '<code>$1</code>', $message );
         $message = preg_replace( '!{{{(.*?)}}}!sm', '<code>$1</code>', $message );
-
         $message = preg_replace( '!\[([^] ]+) ([^]]+)\]!i', '<a href="$1">$2</a>', $message );
 
-        // Escape shortcodes, but that takes out changesets..
-        // $message = str_replace( [ '[', ']'], [ '[[', ']]' ], $message );
+        // Mark up the text, using functions we want, rather than `the_content` as it has many filters that don't strictly apply.
+        $message = wptexturize( $message );
+        $message = wpautop( $message );
+        $message = make_clickable( $message );
 
-        // Might need to disable this, or escape more things prior to it.
-        $message = apply_filters( 'the_content', $message );
-        $message = make_clickable( $message );
+        // Link tickets and changesets.
+        if ( function_exists( 'markup_wporg_links' ) ) {
+                $message = markup_wporg_links( $message );
+        }
+
+        // Ensure nothing funny is in the output.
+        $message = wp_kses_post( $message );
 
         return $message;