Changeset 1139

Timestamp:

01/14/2015 12:20:37 PM (10 years ago)

Author:

ocean90

Message:

i18n Teams: Improve translation counts.

• Fix division by zero warning.
• Show 0% for locales which have the projects, but without translations.

see #340.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/wp-i18n-teams

Files:

• views/all-locales.php (modified) (2 diffs)
• wp-i18n-teams.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wp-i18n-teams/views/all-locales.php

@@ -62 +62 @@
                     <td class="right no-right-border">
                         <a href="https://translate.wordpress.org/languages/<?php echo $locale->slug; ?>">
-                            <?php echo ! empty( $percentages[ $locale->wp_locale ] ) ? $percentages[ $locale->wp_locale ] . '%' : '&mdash;'; ?>
+                            <?php echo ( isset( $percentages[ $locale->wp_locale ] ) ) ? $percentages[ $locale->wp_locale ] . '%' : '&mdash;'; ?>
                         </a>
                     </td>
@@ -79 +79 @@
     </table>
 </div> <!-- /.translators-info -->
-

sites/trunk/wordpress.org/public_html/wp-content/plugins/wp-i18n-teams/wp-i18n-teams.php

@@ -174 +174 @@
         }
         foreach ( $counts as $locale => $count ) {
-            $percentages[ $locale ] = floor( $count['current'] / $count['total'] * 100 );
+            $percentages[ $locale ] = ( $count['total'] > 0 ) ? floor( $count['current'] / $count['total'] * 100 ) : 0;
         }
         set_transient( 'core_translation_data', $percentages, 900 );