Changeset 11474 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

Timestamp:

01/25/2022 10:08:28 PM (5 years ago)

Author:

Otto42

Message:

Themes: Uploader requires the has_reserved_slug to run before get_theme_post, as it says in one of the comments. Not sure when this got moved around, but it broke the uploader quite badly for default theme uploads.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -424 +424 @@
                 }
 
-                // Populate the theme post.
-                if ( ! $this->theme_post ) {
-                        $this->theme_post = $this->get_theme_post();
-                }
-
                 // Populate author.
                 if ( ! $this->author ) {
@@ -450 +445 @@
                                 )
                         );
+                }
+
+                // Populate the theme post.
+                // Like it says above, the has_reserved_slug() function *must* run before this.
+                if ( ! $this->theme_post ) {
+                        $this->theme_post = $this->get_theme_post();
                 }