Changeset 11533 for sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-bbp-term-subscription/inc/class-plugin.php

Timestamp:

02/09/2022 01:20:09 AM (5 years ago)

Author:

dd32

Message:

Support Forums: Record stats on the number of subscriptions added/removed/notified per day.

This will hopefully be used to determine if more people unsubscribe from emails over time in response to any improvements we make.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-bbp-term-subscription/inc/class-plugin.php (modified) (9 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-bbp-term-subscription/inc/class-plugin.php

@@ -248 +248 @@
 
                 // Replace forum subscriber list with term subscribers, avoiding duplicates.
-                add_filter( 'bbp_forum_subscription_user_ids', array( $this, 'add_term_subscribers_to_forum' ) );
+                add_filter( 'bbp_forum_subscription_user_ids', array( $this, 'add_term_subscribers' ) );
 
                 // Actually notify our term subscribers.
@@ -254 +254 @@
 
                 // Remove filters.
-                remove_filter( 'bbp_forum_subscription_user_ids',     array( $this, 'add_term_subscribers_to_forum' ) );
+                remove_filter( 'bbp_forum_subscription_user_ids',     array( $this, 'add_term_subscribers' ) );
                 remove_filter( 'bbp_forum_subscription_mail_message', array( $this, 'replace_forum_subscription_mail_message' ), 10 );
 
@@ -262 +262 @@
          * Temporarily replace the forum subscriber list with any unincluded term subscribers.
          */
-        public function add_term_subscribers_to_forum( $users ) {
+        public function add_term_subscribers( $users ) {
                 return array_diff( $this->subscribers, $users );
         }
@@ -369 +369 @@
 
                 // Replace forum subscriber list with term subscribers, avoiding duplicates.
-                add_filter( 'bbp_topic_subscription_user_ids', array( $this, 'add_term_subscribers_to_topic' ) );
+                add_filter( 'bbp_topic_subscription_user_ids', array( $this, 'add_term_subscribers' ) );
 
                 // Actually notify our term subscribers.
@@ -375 +375 @@
 
                 // Remove filters.
-                remove_filter( 'bbp_topic_subscription_user_ids', array( $this, 'add_term_subscribers_to_topic' ) );
+                remove_filter( 'bbp_topic_subscription_user_ids', array( $this, 'add_term_subscribers' ) );
                 remove_filter( 'bbp_subscription_mail_message',   array( $this, 'replace_topic_subscription_mail_message' ) );
-        }
-
-        /**
-         * Temporarily replace the forum subscriber list with any unincluded term subscribers.
-         */
-        public function add_term_subscribers_to_topic( $users ) {
-                return array_diff( $this->subscribers, $users );
         }
 
@@ -566 +559 @@
          * @return bool False if invalid, otherwise true
          */
-        public static function add_user_subscription( $user_id = 0, $term_id = 0 ) {
+        public static function add_user_subscription( $user_id, $term_id ) {
                 if ( empty( $user_id ) || empty( $term_id ) ) {
                         return false;
@@ -575 +568 @@
                         wp_cache_delete( 'wporg_bbp_get_term_subscribers_' . $term_id, 'bbpress_users' );
                 }
+
                 do_action( 'wporg_bbp_add_user_term_subscription', $user_id, $term_id );
 
@@ -587 +581 @@
          * @return bool False if invalid, otherwise true
          */
-        public static function remove_user_subscription( $user_id = 0, $term_id = 0 ) {
+        public static function remove_user_subscription( $user_id, $term_id ) {
                 if ( empty( $user_id ) || empty( $term_id ) ) {
                         return false;
@@ -596 +590 @@
                         wp_cache_delete( 'wporg_bbp_get_term_subscribers_' . $term_id, 'bbpress_users' );
                 }
+
                 do_action( 'wporg_bbp_remove_user_term_subscription', $user_id, $term_id );