Changeset 11536 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/standalone/class-plugins-info-api-request.php

Timestamp:

02/10/2022 12:57:43 AM (5 years ago)

Author:

dd32

Message:

Plugin Directory: API: Turning off sections should turn off reviews unless explicitely turned on.

This allows for sections to be turned off, without also having to turn off reviews explicitly, while allowing reviews without sections.

Follow up to [11535].
See #6032.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/standalone/class-plugins-info-api-request.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/standalone/class-plugins-info-api-request.php

@@ -118 +118 @@
         );
 
+        // Fields that affect other fields.
+        // If the key is disabled, disable all of the values here unless client turns them on.
+        static $field_interconnected = array(
+                'sections' => [ 'reviews' ], // If sections is disabled, reviews should be disabled unless explicit.
+        );
+
         public function __construct( $args ) {
                 $args = (object) $args;
@@ -203 +209 @@
                         $field = self::$field_aliases[ $field ] ?? $field;
 
+                        // Disable linked fields if required.
+                        if ( ! $include && isset( self::$field_interconnected[ $field ] ) ) {
+                                foreach ( self::$field_interconnected[ $field ] as $linked_field ) {
+                                        if ( ! isset( $fields[ $linked_field ] ) ) {
+                                                $requested_fields[ $linked_field ] = false;
+                                        }
+                                }
+                        }
+
                         // If it's a valid field, include it.
                         if ( isset( self::$fields[ $field ] ) ) {