Changeset 11539

Timestamp:

02/10/2022 02:36:15 AM (4 years ago)

Author:

dd32

Message:

Trac: Don't alter the reporters ticket description/summary when a Gardener comments/edits a field.

Fixes #5866.

Location:

sites/trunk

Files:

• trac.wordpress.org/templates/site.html (modified) (1 diff)
• wordpress.org/public_html/style/trac/wp-trac.js (modified) (2 diffs)

sites/trunk/trac.wordpress.org/templates/site.html

@@ -5 +5 @@
 
 <?python
-    scripts_version = '159'
+    scripts_version = '160'
     project_slug = req.environ['HTTP_HOST'].split(':')[0].split('.')[0]
     wporg_endpoint = 'https://make.wordpress.org/' + project_slug + '/'

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -551 +551 @@
                 var $summary     = $( '#field-summary' ),
                     $description = $( '#field-description' ),
-                    $comment     = $( '#comment' );
+                    $comment     = $( '#comment' ),
+                    isNewTicket  = wpTrac.isNewTicket();
 
                 // Simple replacement for ticket summary.
-                $summary.val( $summary.val().replace( 'Wordpress', 'WordPress' ) );
+                if ( isNewTicket ) {
+                    $summary.val( $summary.val().replaceAll( 'Wordpress', 'WordPress' ) );
+                }
 
                 // Use the more judicious replacement for ticket description and comments.
                 $.each( [ ' Wordpress', '‘Wordpress', '“Wordpress', '>Wordpress', '(Wordpress' ], function( index, value ) {
-                    var replacement = value.replace( 'Wordpress', 'WordPress' );
-
-                    if ( $description.length ) {
-                        $description.val( $description.val().replace( value, replacement ) );
+                    var replacement = value.replaceAll( 'Wordpress', 'WordPress' );
+
+                    if ( $description.length && isNewTicket ) {
+                        $description.val( $description.val().replaceAll( value, replacement ) );
                     }
                     if ( $comment.length ) {
-                        $comment.val( $comment.val().replace( value, replacement ) );
+                        $comment.val( $comment.val().replaceAll( value, replacement ) );
                     }
                 } );
@@ -2059 +2062 @@
 
 })(jQuery);
+
+/**
+ * String.prototype.replaceAll() polyfill. For Internet Explorer.
+ * 
+ * https://gomakethings.com/how-to-replace-a-section-of-a-string-with-another-one-with-vanilla-js/
+ * https://vanillajstoolkit.com/polyfills/stringreplaceall/
+ *
+ * @author Chris Ferdinandi
+ * @license MIT
+ */
+if ( ! String.prototype.replaceAll ) {
+    String.prototype.replaceAll = function(str, newStr) {
+
+        // If a regex pattern
+        if ( Object.prototype.toString.call(str).toLowerCase() === '[object regexp]' ) {
+            return this.replace(str, newStr);
+        }
+
+        // If a string
+        return this.replace(new RegExp(str, 'g'), newStr);
+
+    };
+}