Changeset 11540

Timestamp:

02/10/2022 03:52:34 AM (4 years ago)

Author:

dd32

Message:

Trac: Calculate the correct Core Ticket popover position via Javascript upon opening the popover.

Thix fixes the positioning for mobile views (<770px) and ensures that future header changes don't need the CSS updating.

Fixes #6038.

Location:

sites/trunk

Files:

• trac.wordpress.org/templates/site.html (modified) (1 diff)
• wordpress.org/public_html/style/trac/wp-trac.js (modified) (3 diffs)

sites/trunk/trac.wordpress.org/templates/site.html

@@ -5 +5 @@
 
 <?python
-    scripts_version = '160'
+    scripts_version = '161'
     project_slug = req.environ['HTTP_HOST'].split(':')[0].split('.')[0]
     wporg_endpoint = 'https://make.wordpress.org/' + project_slug + '/'

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -699 +699 @@
 
         reports: function() {
-            var popup = $( '#report-popup' ), failed = false;
+            var popup = $( '#report-popup' ),
+                $headline = $( '#headline' ),
+                failed = false;
+
             $( '#report-popup' ).on( 'change', '.tickets-by-topic', function() {
                 var topic = $(this).val();
@@ -708 +711 @@
                 return false;
             });
+
             popup.appendTo( '#main' );
+
             $( '.open-ticket-report' ).click( function( event ) {
                 // Allow opening the report on make.
@@ -714 +719 @@
                     return;
                 }
+
+                // Calculate the correct position, even if the header size/etc changes.
+                popup.css( 'top', ( $headline.offset().top + $headline.outerHeight() ) + 'px' );
 
                 if ( popup.children().length === 0 ) {