Changeset 11570

Timestamp:

02/17/2022 07:14:23 AM (4 years ago)

Author:

dd32

Message:

Trac: Reorganise how the click handler for the component suggestion works, sometimes the click handler wouldn't register that the component had been clicked.

See #6078.

Location:

sites/trunk

Files:

• trac.wordpress.org/templates/site.html (modified) (1 diff)
• wordpress.org/public_html/style/trac/wp-trac.js (modified) (2 diffs)

sites/trunk/trac.wordpress.org/templates/site.html

@@ -5 +5 @@
 
 <?python
-        scripts_version = '162'
+        scripts_version = '163'
         project_slug = req.environ['HTTP_HOST'].split(':')[0].split('.')[0]
         wporg_endpoint = 'https://make.wordpress.org/' + project_slug + '/'

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -1987 +1987 @@
                                 if ( ! noticeDiv ) {
                                         noticeDiv = $( '<div id="componentSuggest"/>' ).insertBefore( $( '.buttons').first() );
+
+                                        noticeDiv.on( 'click', 'a.component', function(e) {
+                                                e.preventDefault();
+                                                const component = $(this).text();
+
+                                                $( `#field-component option[value="${component}"]` ).prop( 'selected', 'selected' ).change();
+                                        } );
                                 }
                                 noticeDiv.html( getNoticeHTML( matchingComponents ) );
@@ -2004 +2011 @@
 
                                 if ( hasMatches ) {
-                                        template.append( $('<ul/>' ) );
-                                        ulList = template.find('ul');
-
-                                        ulList.on( 'click', 'a', function(e) {
-                                                e.preventDefault();
-                                                const component = $(this).text();
-
-                                                $( `#field-component option[value="${component}"]` ).prop( 'selected', 'selected' ).change();
+                                        ulList = $('<ul/>' );
+
+                                        matchingComponents.forEach( (component) => {
+                                                ulList.append( $( `<li><a href="#" class="component">${component}</a></li>` ) );
                                         } );
-
-                                        matchingComponents.forEach( (component) => {
-                                                ulList.append( $( `<li><a href="#">${component}</a></li>` ) );
-                                        } );
+                                        template.append( ulList );
                                 }