Changeset 11615

Timestamp:

02/25/2022 06:51:15 AM (3 years ago)

Author:

dd32

Message:

Login: Attach the reCaptcha v3 results to the correct form. Take Two.

In [11486] I used the wrong selector function, which resulted in Javascript warnings on some pages.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/functions.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/functions.php

@@ -96 +96 @@
         'recaptcha-api',
         'function onSubmit(token) {
-            var form = document.getElementById("registerform");
-
+            var form = document.querySelector( "#registerform, form:not(#language-switcher)" );
+
+            if ( ! form ) {
+                return;
+            }
+
+            // This is used for the interaction with the invisible v3 recaptcha. 
             if ( form.dataset.submitReady ) {
                 form.submit();
@@ -131 +136 @@
                 // Add the token to the "primary" form
                 var input = document.createElement( "input" ),
-                    form = document.getElementById( "registerform" );
+                    form = document.querySelector( "#registerform, form:not(#language-switcher)" );
 
                 if ( ! form ) {
-                    form = document.querySelectorAll( "form:not(#language-switcher)" );
+                    return;
                 }
 
@@ -143 +148 @@
                 form.appendChild( input );
 
+                // If the visual reCaptcha v2 is not loaded, this data point will never be used.
                 if ( form.dataset.submitReady ) {
                     form.submit();