Changeset 11641 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

Timestamp:

03/04/2022 04:20:31 AM (3 years ago)

Author:

dd32

Message:

Theme Directory: Filter the theme tags to those the directory knows about.

This prevents the code attempting to add a new term when a theme specifies an 'unknown' tag, causing the tag update to be ignored.

Fixes #6160.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -1262 +1262 @@
         // Otherwise create it for this new theme.
         } else {
+
+            // Filter the tags to those that exist on the site already.
+            $tags = array_intersect(
+                $this->theme->get( 'Tags' ),
+                get_terms( array(
+                    'hide_empty' => false,
+                    'taxonomy' => 'post_tag',
+                    'fields' => 'slugs'
+                ) )
+            );
+
             $post_id = wp_insert_post( array(
                 'post_author'    => $this->author->ID,
@@ -1273 +1284 @@
                 'ping_status'    => 'closed',
                 'post_type'      => 'repopackage',
-                'tags_input'     => $this->theme->get( 'Tags' ),
+                'tags_input'     => $tags,
             ) );
         }