Changeset 11665

Timestamp:

03/11/2022 06:52:36 AM (4 years ago)

Author:

dd32

Message:

Trac: PRs: Gracefully handle API failures better.

Avoids Notices when the api_request() function fails.

File:

• sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/functions.php (modified) (3 diffs)

sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/functions.php

@@ -21 +21 @@
         [ 'Accept: application/vnd.github.antiope-preview+json' ]
     );
-    if ( !empty( $raw_check_runs->check_runs ) ) {
+    if ( ! empty( $raw_check_runs->check_runs ) ) {
         foreach ( $raw_check_runs->check_runs as $check ) {
             switch ( $check->status ) {
@@ -50 +50 @@
     );
     $reviews = [];
-    foreach ( $_reviews as $r ) {
-        if (
-            in_array( $r->state, [ 'CHANGES_REQUESTED', 'APPROVED' ] ) &&
-            ! in_array( $r->user->login, $reviews[ $r->state ] ?? [], true )
-        ) {
-            $reviews[ $r->state ][] = $r->user->login;
+    if ( $_reviews ) {
+        foreach ( $_reviews as $r ) {
+            if (
+                in_array( $r->state, [ 'CHANGES_REQUESTED', 'APPROVED' ] ) &&
+                ! in_array( $r->user->login, $reviews[ $r->state ] ?? [], true )
+            ) {
+                $reviews[ $r->state ][] = $r->user->login;
+            }
         }
     }
@@ -65 +67 @@
         [ 'Accept: application/vnd.github.antiope-preview+json' ]
     );
-    foreach ( $_files as $f ) {
-        if ( preg_match( '!(^tests/|/tests/)!', $f->filename ) ) {
-            $touches_tests = true;
-            break;
+    if ( $_files ) {
+        foreach ( $_files as $f ) {
+            if ( preg_match( '!(^tests/|/tests/)!', $f->filename ) ) {
+                $touches_tests = true;
+                break;
+            }
         }
     }