Changeset 11669

Timestamp:

03/12/2022 12:45:19 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Make, Trac Notifications: Properly encode ampersand in component names.

Follow-up to [7664], [11668].

See #6182.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php

@@ -325 +325 @@
                 }
 
+                $component = str_replace( '&', '&', $post->post_title );
+
                 ob_start();
 
                 if ( ! is_singular() ) {
-                        $this->ticket_table( $post->post_title );
+                        $this->ticket_table( $component );
                         return ob_get_clean();
                 }
@@ -398 +400 @@
                 }
 
-                $this->ticket_table( $post->post_title );
-
-                $this->trac_content( $post->post_title );
+                $this->ticket_table( $component );
+
+                $this->trac_content( $component );
 
                 echo '<h3>Help maintain this component</h3>';
@@ -427 +429 @@
                 echo "<strong>Want to help? Start following this component!</strong> <a href='/{$this->trac}/notifications/'>Adjust your notifications here</a>. Feel free to dig into any ticket." . "\n\n";
 
-                $followers = $this->api->get_component_followers( $post->post_title );
+                $followers = $this->api->get_component_followers( $component );
                 if ( $followers ) {
                         $followers = "'" . implode( "', '", esc_sql( $followers ) ) . "'";
@@ -681 +683 @@
                 }
 
-                $component = $post->post_title;
+                $component = str_replace( '&amp;', '&', $post->post_title );
+
                 $history = $this->api->get_component_history( $component );