Changeset 11690

Timestamp:

03/21/2022 10:07:45 PM (3 years ago)

Author:

coffee2code

Message:

Photo Directory, Uploads: Move file upload input field to top of submit form.

Better to front-load required fields (which file upload is), whereas description (which previously appeared before it) was optional. And it makes better sense to progress from picking/seeing the photo and then describing it.

Props topher1kenobe.
Fixes #6092.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/uploads.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/uploads.php

@@ -724 +724 @@
                 $content .= '[input type="hidden" name="post_title" value=""]' . "\n";
                 $content .= sprintf(
+                    '[input type="file" name="ug_photo" id="ug_photo" description="%s" required="true" aria-required="true"]' . "\n",
+                    esc_attr( __( 'Photo', 'wporg-photos' ) )
+                )
+                . sprintf(
                     '[%s name="post_content" class="textarea" id="ug_content" description="%s" maxlength="%d" help="%s"]' . "\n",
                     $description_shortcode,
@@ -729 +733 @@
                     self::MAX_LENGTH_DESCRIPTION,
                     esc_attr( sprintf( __( 'Maximum of %d characters.', 'wporg-photos' ), self::MAX_LENGTH_DESCRIPTION ) )
-                )
-                . sprintf(
-                    '[input type="file" name="ug_photo" id="ug_photo" description="%s" required="true" aria-required="true"]' . "\n",
-                    esc_attr( __( 'Photo', 'wporg-photos' ) )
                 )
                 . '<div class="upload-checkbox-wrapper">' . "\n";