Changeset 11761 for sites/trunk/common/includes/slack/props/lib.php

Timestamp:

04/11/2022 09:01:21 PM (3 years ago)

Author:

iandunn

Message:

Slack: Return results instead of echoing for testability.

File:

• sites/trunk/common/includes/slack/props/lib.php (modified) (4 diffs)

sites/trunk/common/includes/slack/props/lib.php

@@ -5 +5 @@
 
 function show_error( $user ) {
-    echo "Please use `/props SLACK_USERNAME MESSAGE` to give props.\n";
+    return "Please use `/props SLACK_USERNAME MESSAGE` to give props.\n";
 }
 
+/**
+ * Receive `/props` request and send to `#props`.
+ *
+ * @param array $data
+ * @param bool  $force_test Send to test channel instead of #props
+ *
+ * @return string
+ */
 function run( $data, $force_test = false ) {
     $sender = $data['user_name'];
 
     if ( $data['command'] !== '/props' ) {
-        echo "???\n";
-        return;
+        return "???\n";
     }
 
     if ( empty( $data['text'] ) ) {
-        show_error( $sender );
-        return;
+        return show_error( $sender );
     }
 
@@ -26 +32 @@
 
     if ( ! strlen( $receiver ) || ! strlen( $message ) ) {
-        show_error( $sender );
-        return;
+        return show_error( $sender );
     }
 
@@ -43 +48 @@
         $send->set_icon( call_user_func( $get_avatar, $sender, $data['user_id'], $data['team_id'] ) );
     }
-    
+
     if ( $force_test ) {
         $send->testing( true );
@@ -50 +55 @@
     $send->send( '#props' );
 
-    printf( "Your props to @%s have been sent.\n", $receiver );
+    return sprintf( "Your props to @%s have been sent.\n", $receiver );
 }