Changeset 11786

Timestamp:

04/25/2022 10:24:36 PM (3 years ago)

Author:

iandunn

Message:

Props: Pop giver from array to avoid lookup failure.

The users are indexed by Slack ID now, rather than sequentially.

See ​https://wordpress.slack.com/archives/C0FRG66LR/p1650921688316429?thread_ts=1650918540.182309&cid=C0FRG66LR

File:

• sites/trunk/common/includes/slack/props/lib.php (modified) (1 diff)

sites/trunk/common/includes/slack/props/lib.php

@@ -71 +71 @@
     }
 
-    $giver_user          = map_slack_users_to_wporg( array( $request->event->user ) )[0];
+    $giver_user          = map_slack_users_to_wporg( array( $request->event->user ) );
+    $giver_user          = array_pop( $giver_user );
     $recipient_slack_ids = get_recipient_slack_ids( $request->event->blocks );
+
+    // You have to have a w.org account to have a Slack account, so this should always be populated.
+    // The 'Received props from @...' would be broken if the giver can't be found.
+    // Don't throw if a recipient lookup fails, since we still want other recipients to get props.
+    if ( empty( $giver_user ) ) {
+        throw new Exception( 'w.org user lookup for slack ID '. $request->event->user .' failed' );
+    }
 
     if ( empty( $recipient_slack_ids ) ) {