Changeset 11806 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-capabilities.php

Timestamp:

04/28/2022 03:42:10 AM (4 years ago)

Author:

dd32

Message:

Plugins: Release Management: Include Disabled plugins in the Release Management UI, but restrict confirmation to plugin reviewers.

Props ipstenu for the report.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-capabilities.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-capabilities.php

@@ -64 +64 @@
                     'plugin_self_transfer',
                     'plugin_self_close',
-                    'plugin_manage_releases',
                 )
             )
         ) {
             $required_caps[] = 'do_not_allow';
+        }
+
+        // Disable (or restrict to reviewers) release management.
+        if ( 'plugin_manage_releases' === $cap ) {
+            if ( 'disabled' === $post->post_status ) {
+                // Plugin reviewers can approve for disabled plugins.
+                $required_caps[] = 'plugin_review';
+            } elseif ( 'publish' !== $post->post_status ) {
+                // A non-published plugin cannot have it's releases approved.
+                $required_caps[] = 'do_not_allow';
+            }
         }