Changeset 11814

Timestamp:

05/04/2022 07:09:14 AM (4 years ago)

Author:

dd32

Message:

Plugin Directory: Release Management: When displaying the shortcode, check if headers have been sent before attempting a redirect to avoid Warnings.

This only happens for logged in users who do not have any plugins.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-release-confirmation.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-release-confirmation.php

@@ -25 +25 @@
 
                 if ( ! $plugins ) {
-                        wp_safe_redirect( home_url( '/developers/' ) );
-                        // Redirect via JS too, as technically the page output should've already started (but probably hasn't on WordPress.org)
+                        if ( ! headers_sent() ) {
+                                wp_safe_redirect( home_url( '/developers/' ) );
+                        }
+
+                        // Redirect via JS too, as technically the page output should've already started.
                         echo '<script>document.location=' . json_encode( home_url( '/developers/' ) ) . '</script>';
                         exit;