Changeset 11840

Timestamp:

05/13/2022 03:29:05 AM (3 years ago)

Author:

dd32

Message:

Plugin Directory: Validate that the 'stable_tag' used for plugin updates is correct, in addition to the version field.

This cron task is only to catch data inconsistencies, and shouldn't be required, but sometimes it catches an inconsistency and fixes it for us.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-api-update-updater.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-api-update-updater.php

@@ -25 +25 @@
                 LEFT JOIN {$wpdb->prefix}update_source u ON p.ID = u.plugin_id
                 LEFT JOIN {$wpdb->postmeta} pm ON p.ID = pm.post_id AND pm.meta_key = 'version'
+                LEFT JOIN {$wpdb->postmeta} pm_stable ON p.ID = pm_stable.post_id AND pm_stable.meta_key = 'stable_tag'
             WHERE
                 p.post_type = 'plugin'
@@ -35 +36 @@
                     u.last_updated != p.post_modified OR
                     ( u.version != pm.meta_value AND u.version != left( pm.meta_value, 128 ) ) OR
+                    ( u.stable_tag != pm_stable.meta_value AND u.stable_tag != left( pm_stable.meta_value, 128 ) ) OR
                     ( u.available = 1 AND (p.post_status != 'publish' AND p.post_status != 'disabled' ) ) OR
                     ( u.available = 0 AND (p.post_status = 'publish' OR p.post_status = 'disabled' ) )