Changeset 1186

Timestamp:

01/23/2015 11:45:17 PM (10 years ago)

Author:

dd32

Message:

WordPress.org Notifications: Avoid two PHP Notices from unset variables/array indicies

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications.php

@@ -118 +118 @@
         );
         foreach ( $components as $component ) {
-            if ( false === $tree[ $component ] ) {
+            if ( isset( $tree[ $component ] ) && false === $tree[ $component ] ) {
                 continue;
             } elseif ( isset( $subcomponents[ $component ] ) ) {
@@ -528 +528 @@
                 echo "<ul>\n";
                 foreach ( $subcomponents as $subcomponent ) {
-                    $i++;
                     $checked = checked( ! empty( $notifications['component'][ $subcomponent ] ), true, false );
                     echo '<li><label><input type="checkbox" ' . $checked . 'name="notifications[component][' . esc_attr( $subcomponent ) . ']" /> ' . $subcomponent . "</label></li>\n";