Changeset 11974

Timestamp:

07/18/2022 08:08:41 PM (4 years ago)

Author:

iandunn

Message:

GP Profiles: Send notifications for single reviews.

See ​https://github.com/WordPress/five-for-the-future/issues/196

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-profiles/profiles.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-profiles/profiles.php

@@ -49 +49 @@
                 $new_translation->translation_set_id
         );
+
+        $activities            = array();
+        $review_status         = gp_post( 'status' );
+        $valid_review_statuses = array( 'current', 'rejected', 'fuzzy' );
+        $is_reviewing          = $current_user_is_editor && get_current_user_id() !== $new_translation->user_id &&
+                                 $review_status && in_array( $review_status, $valid_review_statuses, true );
 
         /*
@@ -58 +64 @@
          */
         if ( 'waiting' === $new_translation->status && ! $current_user_is_editor ) {
-                $type = 'glotpress_translation_suggested';
+                $activities[] = array(
+                        'component' => 'glotpress',
+                        'type'      => 'glotpress_translation_suggested',
+                        'user_id'   => $new_translation->user_id,
+                );
 
         // Editor is approving a suggested string.
         // Avoid sending a notification when a `current` post is re-saved, like when dismissing warnings.
         } elseif ( 'current' === $new_translation->status && isset( $previous_translation->status ) && 'current' !== $previous_translation->status ) {
-                $type = 'glotpress_translation_approved';
-
-        } else {
+                $activities[] = array(
+                        'component' => 'glotpress',
+                        'type'      => 'glotpress_translation_approved',
+                        'user_id'   => $new_translation->user_id,
+                );
+        }
+
+        if ( $is_reviewing ) {
+                $activities[] = array(
+                        'component' => 'glotpress',
+                        'type'      => 'glotpress_translation_reviewed',
+                        'user_id'   => get_current_user_id(),
+                );
+        }
+
+        if ( empty( $activities ) ) {
                 return;
         }
@@ -72 +95 @@
                 'action'    => 'wporg_handle_activity',
                 'component' => 'glotpress',
-                'type'      => $type,
-                'user_id'   => $new_translation->user_id,
+                'activities' => $activities,
         );