Changeset 12014

Timestamp:

08/12/2022 10:32:07 AM (4 years ago)

Author:

amieiro

Message:

Translate: Resolve a problem when users rejects their own translations

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers

Files:

• includes/class-gp-translation-helpers.php (modified) (1 diff)
• js/reject-feedback.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/includes/class-gp-translation-helpers.php

@@ -364 +364 @@
                 }
 
-                wp_register_script( 'gp-comment-feedback-js', plugins_url( '/../js/reject-feedback.js', __FILE__ ), array( 'jquery', 'gp-common', 'gp-editor', 'thickbox' ), '20220801' );
+                wp_register_script( 'gp-comment-feedback-js', plugins_url( '/../js/reject-feedback.js', __FILE__ ), array( 'jquery', 'gp-common', 'gp-editor', 'thickbox' ), '20220812' );
                 gp_enqueue_script( 'gp-comment-feedback-js' );
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/js/reject-feedback.js

@@ -118 +118 @@
                 comment = div.find( 'textarea[name="feedback_comment"]' ).val();
 
-                if ( ! comment.trim().length && ! commentReason.length ) {
+                if ( ( comment === undefined && ! commentReason.length ) || ( ! comment.trim().length && ! commentReason.length ) ) {
                         $gp.editor.set_status( button, status );
                         return;