Changeset 12074

Timestamp:

09/16/2022 05:37:10 PM (3 years ago)

Author:

amieiro

Message:

Fix a incorrect name in a nonce, who broke a new GlotPress status

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins

Files:

• gp-translation-helpers/gp-translation-helpers.php (modified) (1 diff)
• gp-translation-helpers/js/reject-feedback.js (modified) (2 diffs)
• wporg-gp-customizations/templates/translation-row-editor.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/gp-translation-helpers.php

@@ -40 +40 @@
 add_action( 'gp_init', array( 'WPorg_GlotPress_Notifications', 'init' ) );    // todo: include this class in a different plugin.
 add_action( 'gp_init', array( 'WPorg_GlotPress_Customizations', 'init' ) );    // todo: include this class in a different plugin.
-//add_filter( 'gp_enable_changesrequested_status', '__return_true' ); // todo: remove this filter when this plugin will be merged in the GlotPress core.
+add_filter( 'gp_enable_changesrequested_status', '__return_true' ); // todo: remove this filter when this plugin will be merged in the GlotPress core.

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/js/reject-feedback.js

@@ -118 +118 @@
              */
             function toggleButtons( thisObj, event ) {
-                return;
                 var form = thisObj.closest( 'form' );
                 var commentText = form.find( 'textarea[name="feedback_comment"]' ).val();
@@ -154 +153 @@
              */
             function toggleModalButtons( thisObj, event ) {
-                return;
                 var form = thisObj.closest( 'form' );
                 var commentText = form.find( 'textarea[name="modal_feedback_comment"]' ).val();

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/translation-row-editor.php

@@ -254 +254 @@
                                         <button class="button reject" tabindex="-1" data-nonce="<?php echo esc_attr( wp_create_nonce( 'update-translation-status-rejected_' . $translation->id ) ); ?>"><strong>&minus;</strong> <?php _e( 'Reject', 'glotpress' ); ?></button>
                                         <?php if ( apply_filters( 'gp_enable_changesrequested_status', false ) ) : // todo: delete when we merge the gp-translation-helpers in GlotPress ?>
-                                            <button class="button changesrequested" style="display: none;" data-nonce="<?php echo esc_attr( wp_create_nonce( 'update-translation-status-changes_requested_' . $translation->id ) ); ?>" title="<?php esc_attr_e( 'Request changes for this translation. The existing translation will be kept as part of the translation history.', 'glotpress' ); ?>"><strong>&minus;</strong> <?php _ex( 'Request changes', 'Action', 'glotpress' ); ?></button>
+                                            <button class="button changesrequested" style="display: none;" data-nonce="<?php echo esc_attr( wp_create_nonce( 'update-translation-status-changesrequested_' . $translation->id ) ); ?>" title="<?php esc_attr_e( 'Request changes for this translation. The existing translation will be kept as part of the translation history.', 'glotpress' ); ?>"><strong>&minus;</strong> <?php _ex( 'Request changes', 'Action', 'glotpress' ); ?></button>
                                         <?php endif; ?>
                                     <?php endif; ?>