Changeset 1210

Timestamp:

02/02/2015 05:05:58 AM (10 years ago)

Author:

pento

Message:

Slack firehose: Encode ticket title, so that it doesn't cause the link in the Slack message to finish early

File:

• sites/trunk/common/includes/slack/trac/comment-handler.php (modified) (1 diff)

sites/trunk/common/includes/slack/trac/comment-handler.php

@@ -154 +154 @@
         $comment         = $this->format_comment_for_slack();
         $main_attachment = $this->changes ? implode( "\n", $this->changes ) : $comment;
-        $pretext         = sprintf( '*%s updated <%s|#%s %s>*', $this->author, $this->comment_url, $this->ticket_id, $this->title );
+        $pretext         = sprintf( '*%s updated <%s|#%s %s>*', $this->author, $this->comment_url, $this->ticket_id, htmlspecialchars( $this->title, ENT_NOQUOTES ) );
         $fallback        = trim( $pretext, '*' ) . "\n" . $main_attachment;