Changeset 12133

Timestamp:

10/19/2022 02:47:56 AM (2 years ago)

Author:

dd32

Message:

Plugin Directory: Blocks Import: Ignore invalid blocks that don't specify a name or other required fields.

The error codes now read name is a required property of block.json. which doesn't contain block.json[name].
This seems like it may have been broken since the schema-source change in [11410].

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -806 +806 @@
                     $required_valid_props,
                     function( $is_valid, $prop ) use ( $error ) {
-                        return $is_valid && ( false === strpos( $error, $prop ) );
+                        $prop_field = substr( $prop, 11, -1 ); // 'name' in 'block.json[name]'
+                        return (
+                            $is_valid &&
+                            ( false === strpos( $error, $prop ) ) &&
+                            // String in rest_validate_object_value_from_schema()
+                            ( false === strpos( $error, "{$prop_field} is a required property of block.json." ) )
+                        );
                     },
                     true