Changeset 12147

Timestamp:

10/25/2022 05:49:03 PM (3 years ago)

Author:

ryelle

Message:

Patterns API: Update pagination & sort order for fetching patterns.

Use the per_page parameter passed in if it exists, otherwise continue defaulting to 100 patterns. Remove the forced alphabetical title order in favor of the value passed in. Patterns will now be returned in the same order they are viewed on the website. orderby=favorite_count can be used to mirror the "popular" sorting.

Fixes ​https://github.com/WordPress/pattern-directory/issues/529.

File:

• sites/trunk/api.wordpress.org/public_html/patterns/1.0/index.php (modified) (3 diffs)

sites/trunk/api.wordpress.org/public_html/patterns/1.0/index.php

@@ -20 +20 @@
     $old_headers = headers_list();
 
-    // Remove CORS header added by REST API
+    // Remove CORS header added by REST API.
     header_remove( 'access-control-allow-headers' );
 
     $replace = true;
 
-    foreach( headers_list() as $header ) {
+    foreach ( headers_list() as $header ) {
         if ( 'Link: ' === substr( $header, 0, 6) ) {
             $new_header = str_replace( 'https://wordpress.org/patterns/wp-json/wp/v2/wporg-pattern', 'https://api.wordpress.org/patterns/1.0', $header );
@@ -31 +31 @@
             if ( $new_header !== $header ) {
                 header( $new_header, $replace );
-                $replace = false; // Only replace the first time
+                $replace = false; // Only replace the first time.
             }
         }
     }
 
-    return false; // original buffer will be output with no changes
+    return false; // Original buffer will be output with no changes.
 }
 
@@ -71 +71 @@
         $endpoint               = '/wp/v2/wporg-pattern';
         $query_args['_fields']  = 'id,title,content,meta,category_slugs,keyword_slugs,pattern_content';
-        $query_args['per_page'] = 100;
-
-        // Sort alphabetically so that browsing is intuitive. Search will be sorted by rank.
-        if ( ! isset( $query_args['search'] ) ) {
-            $query_args['orderby'] = 'title';
-            $query_args['order']   = 'asc';
-        }
+        $query_args['per_page'] = $query_args['per_page'] ?? 100;
     }