Changeset 12178

Timestamp:

11/01/2022 07:51:18 AM (11 months ago)

Author:

dd32

Message:

Plugin Directory: Release Confirmation: Update the copy of the release-confirmations-enabled email.

Fixes #5698.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• api/routes/class-plugin-release-confirmation.php (modified) (1 diff)
• email/class-base.php (modified) (1 diff)
• email/class-release-confirmation-enabled.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-release-confirmation.php

@@ -131 +131 @@
             $plugin,
             Tools::get_plugin_committers( $plugin->post_name ),
-            []
+            [
+                // Don't include the plugin reviewer who triggered this.
+                'who' => is_admin() ? 'WordPress.org' : null,
+            ]
         );
         $email->send();

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/email/class-base.php

@@ -168 +168 @@
      */
     public function user_text( $user ) {
+        // Allow passing 'who=WordPress.org' instead of a user object.
+        if ( 'WordPress.org' === $user ) {
+            return 'WordPress.org';
+        }
+
         if ( ! $user instanceof WP_User ) {
             $user = new WP_User( $user );

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/email/class-release-confirmation-enabled.php

@@ -16 +16 @@
 
     function body() {
-        /* translators: 1: Plugin Author, 2: Plugin Name, 3: URL to the handbook */
+        /* translators: 1: Plugin Author, 2: User Name, 5: Plugin Name, 4: Plugin URL, 5: Plugin slug, 6: URL to the handbook */
         return sprintf(
             __( 'Howdy %1$s,
 
-Release confirmations are now enabled for %2$s.
+%2$s has enabled release confirmations for the following plugin:
+%3$s
+%4$s
 
-This means that each time you release a new version of %2$s you\'ll be required to confirm the release by following a link in an automated email.
+A new email will be sent to all committers when a new pending release exists for %5$s with a link to the Release Management dashboard.
+
+You, or another committer to the plugin, will be required to confirm the release on that dashboard before WordPress.org processes the newly committed plugin update.
 
 For more information, please read the following handbook article:
-%3$s', 'wporg-plugins' ),
+%6$s', 'wporg-plugins' ),
             $this->user_text( $this->user ),
+            $this->user_text( $this->who ),
             $this->plugin->post_title,
-            'https://developer.wordpress.org/plugins/wordpress-org/' // TODO: Handbook page.
+            get_permalink( $this->plugin ),
+            $this->plugin->post_name,
+            'https://developer.wordpress.org/plugins/wordpress-org/release-confirmation-emails/'
         );
     }