Changeset 12205 for sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/helpers/helper-translation-discussion.php

Timestamp:

11/04/2022 11:01:38 AM (2 years ago)

Author:

akirk

Message:

gp-translation-helpers: Update from Github

Changes:

• Show dropdown of glossary words extracted from the original ​https://github.com/GlotPress/gp-translation-helpers/pull/118
• Show the feedback form open by default ​https://github.com/GlotPress/gp-translation-helpers/pull/133
• Fix email sending bug ​https://github.com/GlotPress/gp-translation-helpers/pull/139
• Add the status of the translation in the discussion ​https://github.com/GlotPress/gp-translation-helpers/pull/104
• Hide new comment form ​https://github.com/GlotPress/gp-translation-helpers/pull/112
• Remove locale-projects template override ​https://github.com/GlotPress/gp-translation-helpers/pull/115

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers

Files:

• . (modified) (1 prop)
• helpers/helper-translation-discussion.php (modified) (6 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers

@@ -10 +10 @@
 phpunit.xml.dist
 tests
+bin

@@ -10 +10 @@
 phpunit.xml.dist
 tests
+bin

sites/trunk/wordpress.org/public_html/wp-content/plugins/gp-translation-helpers/helpers/helper-translation-discussion.php

@@ -161 +161 @@
                 'show_in_rest'      => true,
                 'sanitize_callback' => array( $this, 'sanitize_comment_locale' ),
+                'rewrite'           => false,
+            )
+        );
+
+        register_meta(
+            'comment',
+            'translation_status',
+            array(
+                'description'       => 'Translation status as at when the comment was made',
+                'single'            => true,
+                'show_in_rest'      => true,
+                'sanitize_callback' => array( $this, 'sanitize_comment_translation_status' ),
                 'rewrite'           => false,
             )
@@ -550 +562 @@
         remove_action( 'comment_form_top', 'rosetta_comment_form_support_hint' );
 
-        $post = self::maybe_get_temporary_post( self::get_shadow_post_id( $this->data['original_id'] ) );
-
+        $post   = self::maybe_get_temporary_post( self::get_shadow_post_id( $this->data['original_id'] ) );
         $output = gp_tmpl_get_output(
             'translation-discussion-comments',
@@ -563 +574 @@
                 'project'              => $this->data['project'],
                 'translation_set_slug' => $this->data['translation_set_slug'],
-
             ),
             $this->assets_dir . 'templates'
@@ -666 +676 @@
         }
         return $translation_id;
+    }
+
+    /**
+     * Sets the translation_status meta_key as "unknown" if is not in the accepted values.
+     *
+     * Used as sanitize callback in the register_meta for the "comment" object type,
+     * 'translation_status' meta_key
+     *
+     * @since 0.0.2
+     *
+     * @param string $translation_status The meta_value for the meta_key "translation_status".
+     *
+     * @return string
+     */
+    public function sanitize_translation_status( string $translation_status ): string {
+        if ( ! in_array( $translation_status, array( 'approved', 'rejected', 'waiting', 'current', 'fuzzy', 'changesrequested' ), true ) ) {
+            $translation_status = 'unknown';
+        }
+        return $translation_status;
+
     }
 
@@ -863 +893 @@
 
     $comment_reason = get_comment_meta( $comment->comment_ID, 'reject_reason', true );
+
+    $_translation_status = get_comment_meta( $comment->comment_ID, 'translation_status', true );
 
     $classes = array( 'comment-locale-' . $comment_locale );
@@ -995 +1027 @@
             if ( ! $is_linking_comment ) :
                 if ( $comment_translation_id && $comment_translation_id !== $current_translation_id ) {
-                    gth_print_translation( $comment_translation_id, $args, 'Translation: ' );
+                    $translation_status = '';
+                    if ( $_translation_status ) {
+                        $translation_status = ' (' . $_translation_status . ')';
+                    }
+                    gth_print_translation( $comment_translation_id, $args, 'Translation' . $translation_status . ': ' );
                 }
 

@@ -10 +10 @@
 phpunit.xml.dist
 tests
+bin