Changeset 12234

Timestamp:

11/10/2022 09:00:47 PM (2 years ago)

Author:

coffee2code

Message:

Photo Directory, Uploads: Add JS pre-upload validation to check if submission has same file name as another pending submission from the contributor.

The check is more of a means to immediately alert contributor to a likely duplicate file submission without having to wait upon submission for the actual duplication check. An identical server-side check for this is unnecessary as the file will be checked for actual duplication.

Props roytanck, coffee2code.
See #6537.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory

Files:

• assets/js/submit.js (modified) (1 diff)
• inc/uploads.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/assets/js/submit.js

@@ -207 +207 @@
     }
 
+    // Check for duplicate file name.
+    if ( ! error && PhotoDir.pending_file_names ) {
+        if ( PhotoDir.pending_file_names.includes( field.files[0]?.name ) ) {
+            field.setCustomValidity( PhotoDir.err_duplicate_pending_file_name );
+            error = true;
+        }
+    }
+
     // Check for file size error.
     if ( ! error ) {

sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/uploads.php

@@ -279 +279 @@
                     'user_can_toggle_all_checkboxes' => User::can_toggle_confirmation_checkboxes(),
                     'toggle_all_checkboxes' => __( 'As a contributor of many photos, I am well aware of the requirements listed below and agree to them all.', 'wporg-photos' ),
+
+                    // File names of user's pending submissions.
+                    'err_duplicate_pending_file_name' => __( 'You already have a pending submission with this file name.', 'wporg-photos' ),
+                    'pending_file_names' => User::get_pending_file_names(),
                 ]
             );